Skip to content

fix(icon): ensure icon data is valid #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Conversation

BeADre
Copy link

@BeADre BeADre commented Aug 2, 2021

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

fix #2745

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@BeADre BeADre closed this Aug 3, 2021
@BeADre BeADre reopened this Aug 3, 2021
@haoziqaq
Copy link

haoziqaq commented Aug 3, 2021

I have encountered this problem too, and I hope to merge quickly

@tangjinzhou tangjinzhou merged commit 89c134a into vueComponent:1.x Aug 4, 2021
@gaokun
Copy link
Contributor

gaokun commented Aug 23, 2021

@tangjinzhou
This PR put a warning on the table on Webpack5 (webpack4 is ok).

According to the code, webpack5 assumes we want to use allIcons.default, but default doesn't export by allIcons.

Plz help to check.

// Initial setting

// https://github.com/vueComponent/ant-design-vue/issues/2745
let validIcons = allIcons.default || allIcons;

VueIcon.add(...Object.keys(validIcons).map(key => validIcons[key]));

image

@gaweki
Copy link

gaweki commented Aug 26, 2021

yes @tangjinzhou , version ^1.7.7 warn

 WARNING  Compiled with 1 warning                                                                                                                                                          4:15:53 PM

 warning  in ./node_modules/ant-design-vue/es/icon/index.js

"export 'default' (imported as 'allIcons') was not found in '@ant-design/icons/lib/dist'


  App running at:
  - Local:   http://localhost:8001/ 

@zkwolf
Copy link
Member

zkwolf commented Aug 26, 2021

yes @tangjinzhou , version ^1.7.7 warn

 WARNING  Compiled with 1 warning                                                                                                                                                          4:15:53 PM

 warning  in ./node_modules/ant-design-vue/es/icon/index.js

"export 'default' (imported as 'allIcons') was not found in '@ant-design/icons/lib/dist'


  App running at:
  - Local:   http://localhost:8001/ 

单独开个issue吧

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants