Skip to content

feat: add event update:expandedRowKeys for Table #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2021

Conversation

viruscamp
Copy link

It's same as event expandedRowsChange, but can be used with prop as :expandedRowKeys.sync="expandedRowKeys" for short.

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
    Add the new event update:expandedRowKeys, and keep expandedRowsChange unchange for compatibility.
    So we can use :expandedRowKeys.sync="expandedRowKeys".
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

Find other props can be used with events update:xx, and add the events.
First in Table and Table.Column, later in other components.

If this PR related with other PR or following info. You can type here.

It's same as event expandedRowsChange, but can be used with prop as ':expandedRowKeys.sync="expandedRowKeys"' for short.
@tangjinzhou
Copy link
Member

can you pr this to 1.x branch?
Thanks

@viruscamp viruscamp changed the base branch from master to 1.x April 4, 2021 10:45
@tangjinzhou tangjinzhou merged commit 6fca13f into vueComponent:1.x Apr 4, 2021
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants