Skip to content

fix: avoid emit update:checked twice #3866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2021
Merged

fix: avoid emit update:checked twice #3866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion components/vc-checkbox/src/Checkbox.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ export default defineComponent({
if ('checked' in props) {
this.$refs.input.checked = props.checked;
}
this.__emit('update:checked', eventObj);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

radioGroup checkGroup 会无法触发 update:checked 这个事件 了 全局搜索下 VcCheckbox 看下 group 的逻辑

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok，我去看看

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里没影响啊，https://github.com/vueComponent/ant-design-vue/blob/next/components/checkbox/Checkbox.tsx#L104 ，vcCheckbox emit change,然后通过context调用group的事件， group自己处理update:checked

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 我看错了 看成了 group也是 checked 事件了

this.__emit('change', eventObj);
this.eventShiftKey = false;
},
Expand Down