Skip to content

fix expression compile error #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix expression compile error #3470

wants to merge 2 commits into from

Conversation

lchrennew
Copy link
Contributor

@lchrennew lchrennew commented Dec 30, 2020

When running with less 4 and webpack, the compiled result is like this:

translateY(-13.07106781 / 2) rotate(45deg)

This should be solved using parentheses around the expression.

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

When running with less 4 and webpack, the compiled result is like this:
```
translateY(-13.07106781 / 2) rotate(45deg)
```
This should be solved using parentheses around the expression.
@lchrennew lchrennew mentioned this pull request Jan 4, 2021
1 task
@tangjinzhou
Copy link
Member

ref #3479

@tangjinzhou
Copy link
Member

@John60676 review 下那个 px 要加吗?

@John60676
Copy link
Member

@John60676 review 下那个 px 要加吗?

那个不用加

@tangjinzhou tangjinzhou closed this Jan 5, 2021
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants