fix: declare Tree Component type #3178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amour1688
reviewed
Nov 15, 2020
components/tree/util.ts
Outdated
| // TODO: Move this logic into `rc-tree` | ||
| function traverseNodesKey(rootChildren, callback) { | ||
| function traverseNodesKey(rootChildren: VNode[], callback?: Function) { | ||
| console.log(rootChildren) |
tangjinzhou
requested changes
Nov 17, 2020
| @@ -14,6 +14,46 @@ import { cloneElement } from '../_util/vnode'; | |||
| import { defaultConfigProvider } from '../config-provider'; | |||
|
|
|||
| const TreeNode = VcTree.TreeNode; | |||
|
|
|||
| export interface TreeDataItem { | |||
|
居然全都是可选的。。 |
Amour1688
reviewed
Nov 17, 2020
components/tree/Tree.tsx
Outdated
| checkable?: boolean; | ||
| icon?: any; | ||
| slots?: any; | ||
| scopedSlots?: any; |
There was a problem hiding this comment.
看逻辑上这个属性还是在的，文档上是没了 我给他去掉
|
可以把 props 里面 treeData 的类型也定义一下 |
嗯嗯 |
|
treeData下的children做类型递归有点问题。。 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
This is a ...
Changelog description (Optional if not new feature)
这个tree组件花了挺长时间看的，之前没敢动因为缺失挺多类型的，然后发现了DirectoryTree.tsx文件中lastSelectedKey的默认值是空数组导致类型判断出了问题，在组件中其他位置用法都是string就默认给了个空字符串，这里做了一个小改动，然后添加了一些interface来给这几个组件做声明，字段是按文档给来声明的，如果有缺失或者错误的请指出~~