Skip to content

Change vue cli 3 way of customizing theme #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Change vue cli 3 way of customizing theme #264

merged 1 commit into from
Nov 20, 2018

Conversation

BuonOmo
Copy link
Contributor

@BuonOmo BuonOmo commented Nov 19, 2018

According to the vue cli documentation and my own try, it looks like that the solution proposed before gave an issue, or needed the user to install all loaders.

This solution, however, works like a charm out of the box!

You still have to load the .less file instead of .css, but that is described lower in the documentation.

According to [the vue cli documentation](https://cli.vuejs.org/guide/css.html#passing-options-to-pre-processor-loaders) and my own try, it looks like that the solution proposed before gave an issue, or needed the user to install a dup of all loaders.

This solution, however, works like a charm!
@BuonOmo BuonOmo changed the title Change vue cli 3 way of doing things Change vue cli 3 way of customizing theme Nov 19, 2018
@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #264 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files         137      137           
  Lines        4222     4222           
  Branches     1203     1203           
=======================================
  Hits         3643     3643           
  Misses        551      551           
  Partials       28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1542d11...1778a81. Read the comment docs.

@tangjinzhou tangjinzhou merged commit 4bb9e75 into vueComponent:master Nov 20, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants