feat: update radio #2374
Merged
feat: update radio #2374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amour1688
commented
Jun 6, 2020
63 tasks
Amour1688
force-pushed
the
feat-vue3-radio
branch
from
5445579 to
668fb01
Compare
tangjinzhou
requested changes
Jun 11, 2020
components/radio/Radio.jsx
Outdated
| const props = getOptionProps(this); | ||
| const children = $slots.default; | ||
| const { mouseenter = noop, mouseleave = noop, ...restListeners } = getListeners(this); | ||
| const { onMouseenter = noop, onMouseleave = noop, ...restAttrs } = $attrs; |
There was a problem hiding this comment.
事件的处理 和 v-model 的处理 在理一下 参考 group
components/radio/RadioButton.jsx
Outdated
| } | ||
| return <Radio {...radioProps}>{this.$slots.default}</Radio>; | ||
| return <Radio {...radioProps}>{this.$slots.default()}</Radio>; |
There was a problem hiding this comment.
这个添加 inheritAttrs: false 不然这里的 onChange 和 自动挂载的是如何处理的？ 大概率是合并
|
|
||
| export default { | ||
| name: 'Checkbox', | ||
| mixins: [BaseMixin], | ||
| inheritAttrs: false, | ||
| model: { |
Amour1688
force-pushed
the
feat-vue3-radio
branch
from
668fb01 to
969482c
Compare
|
48dda04 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
This is a ...
What's the background?
API Realization (Optional if not new feature)
What's the effect? (Optional if not new feature)
Changelog description (Optional if not new feature)
Self Check before Merge
Additional Plan? (Optional if not new feature)