Skip to content

feat(style): add @modal-header-border-color-split variable #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2020

Conversation

OzanBarsal
Copy link

@OzanBarsal OzanBarsal commented Apr 30, 2020

This is a Component style update for Modal

What's the background?

We're using antdv as our project's component library. I was looking to change to header split border's color when I realized the less variable was missing.

@modal-footer-border-color-split exists in this project and even @modal-header-border-color-split exists in antd of React library so I thought it makes sense that it also exists here.

I haven't found any issues regarding this, and instead of opening one, I'm opening a PR that adds the variable to default.less and uses it in modal.less

What's the effect?

This change allows the customization of modal component's header's split border's color to be customized separately from other split border colors.

Has no effect unless the variable is set to a different value in a custom theme. No breaking changes.

Resolves #2196

Changelog description

Added @modal-header-border-color-split theme variable.

@tangjinzhou
Copy link
Member

Because the style uses script to synchronize from antd. So you better submit pr to antd first.

@OzanBarsal
Copy link
Author

OzanBarsal commented May 6, 2020

Because the style uses script to synchronize from antd. So you better submit pr to antd first.

Oh that's interesting because the variable exists on antd repo
Just realized that you're syncing styles from a pretty old version of antd is there a specific reason for this?

@tangjinzhou
Copy link
Member

I did not search @modal-header-border-color-split through github, thinking that antd has no relevant features. Hahaha

@tangjinzhou tangjinzhou merged commit 90131e9 into vueComponent:master May 7, 2020
@github-actions
Copy link

github-actions bot commented May 8, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to change header border split color to Modal
2 participants