Skip to content

Merge pull request #1 from vueComponent/master #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zt8989
Copy link

@zt8989 zt8989 commented Feb 17, 2020

sync

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #1794 into master will increase coverage by 0.81%.
The diff coverage is 92.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1794      +/-   ##
==========================================
+ Coverage   87.25%   88.06%   +0.81%     
==========================================
  Files         145      157      +12     
  Lines        4832     5422     +590     
  Branches     1423     1525     +102     
==========================================
+ Hits         4216     4775     +559     
- Misses        572      578       +6     
- Partials       44       69      +25
Impacted Files Coverage Δ
components/date-picker/interface.js 92.3% <ø> (ø) ⬆️
components/anchor/index.jsx 100% <ø> (ø) ⬆️
components/collapse/index.js 100% <ø> (ø) ⬆️
components/date-picker/index.js 100% <ø> (ø) ⬆️
components/button/buttonTypes.js 100% <ø> (ø) ⬆️
components/button/index.js 100% <ø> (ø) ⬆️
components/breadcrumb/index.js 100% <ø> (ø) ⬆️
components/checkbox/index.js 100% <ø> (ø) ⬆️
components/card/index.js 100% <ø> (ø) ⬆️
components/back-top/index.jsx 96.15% <100%> (+0.23%) ⬆️
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47907b...d0aa9ed. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants