Skip to content

Make parentContext optional in ModalOptions type #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2020
Merged

Make parentContext optional in ModalOptions type #1784

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63f1cb7
Make parentContext optional in ModalOptions type
sgarner Feb 14, 2020
8da21a1
Use non-primitive object type for parentContext
sgarner Feb 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/modal.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export interface ModalOptions {
*/
onOk?: () => any;

parentContext: Object;
parentContext?: Object;
}

export interface ModalConfirm {
Expand Down