-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: Adding ant-upload-btn class to the upload component #1742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for ant-desing-vue processing. Building with commit 156c3ad https://app.netlify.com/sites/ant-desing-vue/deploys/5e2deba6631e80000812d0a6 |
Codecov Report
@@ Coverage Diff @@
## master #1742 +/- ##
=======================================
Coverage 88.09% 88.09%
=======================================
Files 157 157
Lines 5416 5416
Branches 1524 1524
=======================================
Hits 4771 4771
Misses 576 576
Partials 69 69
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should change this line to <VcUpload {...vcUploadProps} class={
${prefixCls}-btn}>
https://github.com/vueComponent/ant-design-vue/blob/master/components/upload/Upload.jsx#L276
The requested changes have been made. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This is a ...
What's the background?
It was discovered that when the screen is wider than the upload component content, clicking outside of the content bounding box does not trigger the upload dialog. Dragging a file outside of that box causes the browser to open that file instead of uploading the file.
This bug does not exist on the React version of ant design. After comparing the two versions, it was discovered that the Vue implementation is missing a class on the wrapping
span
, causing the layout for that wrapper to be broken.This PR addresses the issue by adding back the missing class name.
Self Check before Merge