Skip to content

fix: fix the "finish" event of statistic countdown #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hebingchang
Copy link
Contributor

@hebingchang hebingchang commented Jan 15, 2020

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

The @finish event in statistic countdown component doesn't work at all.

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jan 15, 2020

Deploy preview for ant-desing-vue processing.

Building with commit ad4f417

https://app.netlify.com/sites/ant-desing-vue/deploys/5e3c0daabf12960008456f2d

@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #1731 into master will increase coverage by 0.01%.
The diff coverage is 92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1731      +/-   ##
==========================================
+ Coverage   88.04%   88.05%   +0.01%     
==========================================
  Files         157      157              
  Lines        5410     5417       +7     
  Branches     1524     1524              
==========================================
+ Hits         4763     4770       +7     
  Misses        578      578              
  Partials       69       69
Impacted Files Coverage Δ
components/tag/Tag.jsx 91.66% <ø> (ø) ⬆️
components/time-picker/index.jsx 77.41% <ø> (ø) ⬆️
components/card/Grid.jsx 100% <ø> (ø) ⬆️
components/date-picker/wrapPicker.js 97.95% <ø> (ø) ⬆️
components/avatar/Avatar.jsx 96.15% <ø> (ø) ⬆️
components/rate/index.jsx 100% <ø> (ø) ⬆️
components/list/index.jsx 89.74% <ø> (ø) ⬆️
components/spin/Spin.jsx 92.15% <ø> (ø) ⬆️
components/switch/index.jsx 100% <ø> (ø) ⬆️
components/drawer/index.jsx 95.52% <ø> (ø) ⬆️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63f9ea...ad4f417. Read the comment docs.

@tangjinzhou tangjinzhou merged commit ae50539 into vueComponent:master Feb 7, 2020
@github-actions
Copy link

github-actions bot commented Feb 7, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants