Skip to content

fix: tabs trigger nextClick event #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

sendya
Copy link
Member

@sendya sendya commented Nov 30, 2019

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

ant-design-vue 1.4.8 or early a-tabs events nextClick not trigger

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
    fix: tabs trigger nextClick event
  1. Chinese description (optional)
    修复 tabs 组件不触发 nextClick 事件

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

Allow edits from maintainers

@netlify
Copy link

netlify bot commented Nov 30, 2019

Deploy preview for ant-desing-vue processing.

Building with commit 6429e51

https://app.netlify.com/sites/ant-desing-vue/deploys/5de286acddea32000a4ce241

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #1489 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1489   +/-   ##
=======================================
  Coverage   87.92%   87.92%           
=======================================
  Files         156      156           
  Lines        5399     5399           
  Branches     1523     1523           
=======================================
  Hits         4747     4747           
  Misses        583      583           
  Partials       69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ea4bb...6429e51. Read the comment docs.

@tangjinzhou tangjinzhou merged commit b2717bc into vueComponent:master Dec 2, 2019
@github-actions
Copy link

github-actions bot commented Dec 2, 2020

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants