Skip to content

fix: cascader input space bug #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zkwolf
Copy link
Member

@zkwolf zkwolf commented Nov 18, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
    修复cascader组件在搜索时输入空格触发页面滚动的bug
  3. Related issue link.
    Cascader 级联搜索时不能输入空格 #1427

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@netlify
Copy link

netlify bot commented Nov 18, 2019

Deploy preview for ant-desing-vue processing.

Building with commit 3631dce

https://app.netlify.com/sites/ant-desing-vue/deploys/5dd2a6ccee47f80007248a5a

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #1431 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1431      +/-   ##
=========================================
- Coverage   87.92%   87.9%   -0.02%     
=========================================
  Files         156     156              
  Lines        5398    5398              
  Branches     1523    1523              
=========================================
- Hits         4746    4745       -1     
  Misses        583     583              
- Partials       69      70       +1
Impacted Files Coverage Δ
components/cascader/index.jsx 84.97% <100%> (ø) ⬆️
components/upload/UploadList.jsx 89.77% <0%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 930e875...3631dce. Read the comment docs.

@tangjinzhou tangjinzhou merged commit d52ed02 into vueComponent:master Nov 19, 2019
@zkwolf zkwolf deleted the fix-cascader-input-space-bug branch November 19, 2019 09:32
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants