Skip to content

间距margin重置的bug #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Conversation

wangweijun0418
Copy link
Contributor

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

添加menu组件收起张开动画的卡顿现象。

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.
这个是一个menu菜单 margin边距重叠的问题,解决的方法有,加padding ,或border隔离各margin重叠。目前使用overhidden影响比较小。

@netlify
Copy link

netlify bot commented Oct 29, 2019

Deploy preview for ant-desing-vue processing.

Building with commit d870737

https://app.netlify.com/sites/ant-desing-vue/deploys/5db8fc202c0b01000756c71e

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #1353 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1353   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files         156      156           
  Lines        5412     5412           
  Branches     1524     1524           
=======================================
  Hits         4739     4739           
  Misses        598      598           
  Partials       75       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 755517e...d870737. Read the comment docs.

@tangjinzhou
Copy link
Member

ref ant-design/ant-design#19477

解决margin重合问题,overflow方式会有副作用,采用padding解决margin重合现象。
@tangjinzhou tangjinzhou merged commit e1b126c into vueComponent:master Oct 30, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants