-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: fixed error with no expected value in expandColumnTitle
slot
#7265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
用的 renderSlot 的地方都有这个隐患吧,可以全局排查下 |
|
aibayanyu20
suggested changes
Jan 12, 2024
1 task
done |
@cc-hearts 老哥,可以给3.x提个么 |
已经有 3.x的pr了 。 #7252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace vue's private
renderSlot
method with thecustomRenderSlot
method.what
customRenderSlot
does is enhance the wayjsx
is rendered, so that if there is only aComment
orFragment
in theslot
, the default content is rendered, in line with what is expected fromtemplate
rendering.close #7260