camelCase event name in LMarker #334
Labels
Comments
|
@nrmncr thank you nice catch! I will add it to the work to be done :) |
Cl3MM
added a commit
to Cl3MM/Vue2Leaflet
that referenced
this issue
May 27, 2019
Event names should be kebab case, as per [vue recommendations](https://vuejs.org/v2/guide/components-custom-events.html#Event-Names) To avoid breaking changes, we still emit the original event name. This fix closes [issue vue-leaflet#334 ](vue-leaflet#334)
DonNicoJs
pushed a commit
that referenced
this issue
May 27, 2019
Fix #334 - event name should be Kebab case
fdenzer
added a commit
to fdenzer/Vue2Leaflet
that referenced
this issue
Sep 29, 2020
* Add tests for LControlLayers options Testing the addLayer and removeLayer methods is more involved, as this requires interaction with the parent map object and additional child layers of it. These tests are still TODO. * fix unbind tooltip * fix unbind popup * Small marks about create plugins from vue-leaflet#363 * fix unbind tooltip and popup * fix linter error * - Add boolean support in prop LControlAttribution Component * Fix vue-leaflet#334 - event name should be Kebab case Event names should be kebab case, as per [vue recommendations](https://vuejs.org/v2/guide/components-custom-events.html#Event-Names) To avoid breaking changes, we still emit the original event name. This fix closes [issue vue-leaflet#334 ](vue-leaflet#334) * Add test setup to make Leaflet think JSDOM supports SVG * Prevent "error reading property 'lng' of null" on default * Add blank lines between arrange/act/assert steps * Add tests for LCircle latLng and radius props * Add helper to test mixed-in path functionality * Add tests for remaining path mixin properties * Move radius test into test for Circle mixin and include Path there * Prevent "error reading property 'lng' of null" on default CircleMarker * Add tests for LCircleMarker component * Add tests to ensure legitimate falsy values can be set * Add tests for LPolyline.vue and Polyline mixin * removed unnecessary checks. all tests passed * added disableClickPropagation for LControl * returned section in readme about how to run examples locally * chore: disable test with known leaflet bug * chore: npm audit update for packages * 2.2.0 * feat: destroy map on beforeDestroy to prevent memory leak * chore: add a v-if toggle to simple example to replicate memory leak * 2.2.1 * docs: Typo desactivate->deactivate * fix(LMap): reverse noBlockingAnimations * fix(LMap): apply noBlockingAnimations to fitBounds * test: check options after noBlockingAnimations * Fix for typos in Nuxt part Missing dash with registering component LTileLayer and adding a space to import. * Update quickstart.md ssr-only is deprecated and changes to client-only * build(deps): bump eslint-utils from 1.3.1 to 1.4.3 in /examples Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.3.1 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.3.1...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump axios from 0.18.0 to 0.18.1 in /examples Bumps [axios](https://github.com/axios/axios) from 0.18.0 to 0.18.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.18.1/CHANGELOG.md) - [Commits](axios/axios@v0.18.0...v0.18.1) Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump mixin-deep from 1.3.1 to 1.3.2 in /examples Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump lodash from 4.17.11 to 4.17.15 in /examples Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.15) Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump lodash.defaultsdeep from 4.6.0 to 4.6.1 in /examples Bumps [lodash.defaultsdeep](https://github.com/lodash/lodash) from 4.6.0 to 4.6.1. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.6.0...4.6.1) Signed-off-by: dependabot[bot] <[email protected]> * build(deps): bump eslint-utils from 1.3.1 to 1.4.3 Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.3.1 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.3.1...v1.4.3) Signed-off-by: dependabot[bot] <[email protected]> * test(LGeoJSON): add unit tests for LGeoJSON * test(LGeoJSON): fix naming for imports * fix: Use correct types for map bounds These values are passed to Map.fitBounds and MapOptions.maxBounds which both takes in LatLngBoundsExpression, not BoundsExpression. * fix: Fix typo in types for latLngs prop * Update README.md * chore: add nvmrc and update packages * chore: move examples to npm and update packages * chore: remove travis, fix node version * chore: ci config * chore: dedupe babel/types * chore: remove cache, test before build * chore: add prepare stage * chore: fix package, prettier, linting * chore: enable caching * Update README.md * added activated flag for Layers; which will define whether a layer will be added directly to the map or not * feat: add missing options mixins - LCircle - LCircleMarker - LFeatureGroup - LGeoJson - LImageOverlay - LPolygon - LPolyline - LRectangle * 2.3.0 * fix: rework activated logic and move it to visible * 2.3.1 * 2.3.2 * chore: unify linting rules * feat: feature group example * chore: apply prettier lints * feat: enable hideLayer * feat: support layer hiding, and sync with control * feat: linting and add examples for sync visible prop * chore: linting * fix: pass correct props to option binder * 2.4.0 * 2.4.1 * fix: if hideLayer is not defined use removeLayer * 2.4.2 * chore: add stalebot * Add support fo subdomains * Fix * fix: restore visible prop functionality * 2.4.3 * chore: add github actions * chore: prepublishOnly instead of prepare * doc: WIP new docs * feat: finalise new docs * feat: move examples in doc system * feat: finalise docs, remove old examples * chore: fix base url of vuepress and new components docs * chore: update docs links * 2.5.0 * chore: add redirects file for netlify * Revert "chore: add redirects file for netlify" This reverts commit 6488f35. * docs: fix component link * chore: force vuepress in spa mode * Revert "Revert "chore: add redirects file for netlify"" This reverts commit e44d321. * fix: import Icon in function to avoid issue on ssr * 2.5.1 * Fixes vue-leaflet#526 Updated docs for 'L' * feat: remove fixDefaultIcons from codebase * 2.5.2 * 2.5.3 * Revert "2.5.3" This reverts commit f072959. * chore: lock vue dependency to 2.x * chore: fix vue2-leaflet version in codesanbox * docs: update README.md [skip ci] * docs: create .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: create .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Update README.md * Update README.md * docs: add TypeScript remedy to 'marker icons are missing' section * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Update README.md * Offer option for disable scroll propagation in control * Add tests for new prop * map options override prop defaults * possible fix * added 2 unit tests * add to contribs * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * removed contrib * Fix attribution switch when switching tile layers * Crs switching and examples * Added to docs an alternative API access method via LMap event * Add vue-leaflet-minimap plugin. * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Fix typos * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * chore(deps): bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <[email protected]> * Tile layer accepts both a string and a string array for the subdomains prop * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Add vue2-leaflet-fullscreen to plugins list * Install and configure jest-mock-console * fix: Accept any valid `latLngBounds` argument * Set initial center and bounds values from props * Remove unused data var `lastSetZoom` * Clean up bounds object/array test The altered tests used to expect the mock function to be called with a specific object, the expected value of which depends upon side effects of a call to the unmocked underlying Leaflet method. These changes leave the tests expecting only those things explicitly controlled by the mock and by Vue2Leaflet. * Don't set bounds in both `data` and `mounted` * Don't zoom all the way out on null zoom level * Use bounds prop for initial map display when set * Cache both centre and bounds when any prop changes the map view * Don't ignore setting zoom level to 0 * Add description to `options` prop * Add tip and faq around using `options` * Explain options object is not reactive * Make `_getIconUrl` optional in TS example * Bump required rollup-plugin-view version Co-authored-by: Nicolò Maria Mezzopera <[email protected]> Co-authored-by: Michael Underwood <[email protected]> Co-authored-by: anhnhoktvn <[email protected]> Co-authored-by: bezany <[email protected]> Co-authored-by: Muhammad Al Faris <[email protected]> Co-authored-by: Clement ROOLAY <[email protected]> Co-authored-by: bezany <[email protected]> Co-authored-by: Nicolò Maria Mezzopera <[email protected]> Co-authored-by: rishabh <[email protected]> Co-authored-by: javiertury <[email protected]> Co-authored-by: Stan T <[email protected]> Co-authored-by: Ruud Boon <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nicolò Maria Mezzopera <[email protected]> Co-authored-by: Dmitry Zakharov <[email protected]> Co-authored-by: Trygve Aaberge <[email protected]> Co-authored-by: Markus Wolf <[email protected]> Co-authored-by: Imagoiq <[email protected]> Co-authored-by: Andre Mas <[email protected]> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: George Pickering <[email protected]> Co-authored-by: Jonny Sooter <[email protected]> Co-authored-by: Jake Potrebic <[email protected]> Co-authored-by: itanka9 <[email protected]> Co-authored-by: Roman Naumenko <[email protected]> Co-authored-by: Patrick Cate <[email protected]> Co-authored-by: Pierre Grimaud <[email protected]> Co-authored-by: Andi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi!
LMarker component emit event with name 'update:latLng', but according to vue2 documentation (vue2 event names) names must be in kebab-case ('update:lat-lng')
vue2-leaflet v1.2.3
The text was updated successfully, but these errors were encountered: