Toward vuejs v2.0 #89

lionel-bijaoui · 2016-10-07T09:41:21Z

🚧 This is WIP 🚧
current problem by order of importance:

Tests need to be rewritten in some way to fit vuejs 2.0 😅
selectEx: weird warning, problem is not yet identified.
dev app: is not working well and can be simplified with ES6.
validator: weird warning seem to indicate lack of information on initialisation. May be related to dev app or internal problem with vuejs v2.0. Some behavior have changed and things update faster which may or may not be the cause.
noUiSlider: I'm updating it to v9.0 and there is breaking changes and cool new functionality (very useful for my work).
vue multiselect should work now that multiselect: put back custom-label & fix #87 is implemented, but I need to make sure.
updating plugins

Project board : https://github.com/icebob/vue-form-generator/projects/2

icebob · 2016-10-07T10:55:55Z

.babelrc

@@ -1,5 +1,5 @@
 {
-  "presets": ["es2015", "stage-0"],
+  "presets": ["es2015", "stage-2"],
  "plugins": ["transform-runtime"],


Why changed to stage-2 from 0?

stage-2 is the default in the vue-cli webpack preset. It is less bleeding edge, I guess ? I don't mind putting it back to were it was, I just did that when I was debugging to exclude differences between your config and the proposed webpack config.
You use ES7 features ?

Currently not, just I'm using stage-0 in my other projects too.

icebob · 2016-10-07T10:57:51Z

src/fields/abstractField.js

+
+                if (isFunction(this.schema.set)) {
+                    this.schema.set(this.model, newValue);
+                    console.log("model-updated via schema", this.model[this.schema.model]);


Not guaranteed, that this.schema.model is defined. Need to check

BTW, what is this schema.set ? I might have missed it, but I don't recall any explanation about it in the doc.

The set and get in schema can be use for virtual props of model. E.g create a field for fullName but in the model store as firstName and lastName.

{ type: "text", label: "Full name", model: null, get(model) { return model.firstName + " " + model.lastName; }, set(model, val) { let values = val.split(" "); model.firstName = values[0]; model.lastName = values[1]; } }

Or if you want to transform the value. Example

icebob · 2016-10-07T11:14:47Z

webpack.dev.config.js

-		"test": /\.jade?$/,
-		"loader": "jade"
-	},
-	{


In Vue2 these loaders not neccessary?

Well, we don't require any .jade, .scss or .css files. They were never necessary (vue-loader take care of this).
It is also part of my temporary debug changes.
It can came back when everything is working again.

Hmm, you are right. It's a habit :)

icebob · 2016-10-07T11:20:47Z

test/unit/specs/VueFormGenerator.spec.js


 	// console.log(el);

 	return [el, vm];
 }

 describe("VueFormGenerator.vue", () => {
-
+	describe.only("nothing", () => {


It's misleading, because Travis will be green, but no correct testing. In development state there is no problem if Travis red, but show the real results and we know we need to fix it too. 😉

Sorry about that, it was to test the build locally without changing too much. Normally, it is forbidden to push .only(). This will go away when I fix the test. I forget to put it back how it was.

icebob · 2016-11-01T17:18:26Z

Hi, are you working on this upgrade yet?

lionel-bijaoui · 2016-11-03T21:47:04Z

@icebob Sorry I was very busy at work. I will work on it soon.

Add missing opening brace

icebob · 2016-11-25T19:17:36Z

@lionel-bijaoui Do you have any new commit to this PR?
Because maybe next week I'll able to work on vue2 migration. And I want to merge this PR to the next branch.

lionel-bijaoui · 2016-11-28T10:52:44Z

I'm sorry, I'm really squeezed tight at work. I'm not in my normal office and I'm not doing any dev work. It's kinda special for me for the next 2 months.
I'm going to take a look at my PR tomorrow. Worse case scenario, you can use my work as a base. Most of it work well. The unit tests are the biggest job along the validator system.
Sorry I can't be more helpful, I feel really bad about that 😞

icebob · 2016-11-28T11:14:08Z

Thanks, no problem! Just upload your last state and I continue to migration. 😉

# Conflicts: # dev/index.html # src/formGenerator.vue

…-template-compiler). Update vue-loader to 10.0.0.

lionel-bijaoui · 2016-11-30T13:29:35Z

I updated vuejs and integrated all the new changes since the last push. The main problem is the validator that is validating too early. I don't know if it has access to the values or not.
With that, the test need to be fixed and updated.
Lastly, some libs were updated and need to be checked for changes (NoUiSlider for example can now accept an arbitrary number of handle + syntax changes)

icebob · 2016-12-01T15:57:09Z

Thank you!

Lionel Bijaoui added 3 commits October 7, 2016 11:26

[wip] modification to work with vuejs 2.0.

0b1df2c

fix: aligned with issue vue-generators#84

5d6c0c7

fix: rewrite in jade and commenting problematic fields

35be49e

icebob reviewed Oct 7, 2016

View reviewed changes

icebob added 3 commits October 9, 2016 19:30

test: lock multiselect version

5b0a4d0

Update README.md

8128a52

docs: fix npms.io badge url

475eb91

icebob added 5 commits November 3, 2016 16:20

add step attribute to number field vue-generators#92

ce64c4e

remove commit message package

682c6ab

add number prop to input field

a40e23c

🐛 Fix options prop default vue-generators#91

3d2e821

📦 Build

ce72dc4

icebob mentioned this pull request Nov 5, 2016

Failed to compile template #95

Closed

icebob added 3 commits November 5, 2016 21:29

add bower

ce44822

📦 bump version & build

d56f93c

docs: update changelog

6bd9c78

lionel-bijaoui mentioned this pull request Nov 14, 2016

Vue2 #96

Closed

dominik-bln and others added 2 commits November 17, 2016 14:32

Add missing opening brace

6842f1b

Merge pull request vue-generators#97 from dominik-bln/patch-1

26f63de

Add missing opening brace

icebob added 5 commits November 27, 2016 22:07

Fixed bower file syntax error vue-generators#98

06b0022

bump version

1976b4a

📦 Build v0.6.1

79580a2

docs: update changelog

853228d

Update README.md

acd1e22

lionel-bijaoui added 3 commits November 29, 2016 16:41

Merge branch 'lb_next'

ca783ba

# Conflicts: # dev/index.html # src/formGenerator.vue

Update vuejs version to 2.1.3, and made change accordingly (added vue…

61b76c1

…-template-compiler). Update vue-loader to 10.0.0.

Fix a bug with v-model and dynamic type on input.

1d090df

icebob merged commit fc123fe into vue-generators:next Dec 1, 2016

lionel-bijaoui deleted the lb_next branch February 10, 2017 15:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Toward vuejs v2.0 #89

Toward vuejs v2.0 #89

lionel-bijaoui commented Oct 7, 2016

icebob Oct 7, 2016

lionel-bijaoui Oct 7, 2016

icebob Oct 8, 2016

icebob Oct 7, 2016

lionel-bijaoui Oct 7, 2016

icebob Oct 8, 2016

icebob Oct 7, 2016

lionel-bijaoui Oct 7, 2016 •

edited

Loading

icebob Oct 8, 2016

icebob Oct 7, 2016

lionel-bijaoui Oct 7, 2016

icebob Oct 8, 2016

icebob commented Nov 1, 2016

lionel-bijaoui commented Nov 3, 2016

icebob commented Nov 25, 2016

lionel-bijaoui commented Nov 28, 2016

icebob commented Nov 28, 2016

lionel-bijaoui commented Nov 30, 2016 •

edited

Loading

icebob commented Dec 1, 2016

Toward vuejs v2.0 #89

Toward vuejs v2.0 #89

Conversation

lionel-bijaoui commented Oct 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lionel-bijaoui Oct 7, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

icebob commented Nov 1, 2016

lionel-bijaoui commented Nov 3, 2016

icebob commented Nov 25, 2016

lionel-bijaoui commented Nov 28, 2016

icebob commented Nov 28, 2016

lionel-bijaoui commented Nov 30, 2016 • edited Loading

icebob commented Dec 1, 2016

lionel-bijaoui Oct 7, 2016 •

edited

Loading

lionel-bijaoui commented Nov 30, 2016 •

edited

Loading