new: new field 'input'

[lionel-bijaoui]

#50 this is my proposal for this fields.

The test are not amazing for now (they accept any attribute regardless of the input type).

[icebob]

Thank you for your PR. I need more time to check it, ok?

[icebob]

Please change the type to input instead of html5

[icebob]

I think, we can't handle all types with one field. Because for date* types there are extra properties and methods to format date to the input and to the model like here

Do you have any idea how to solve it?

[lionel-bijaoui]

A simple check to see the this.schema.format could be enough:

if (typeof this.schema.format !== "undefined" && value != null) {
    return moment(value, this.schema.format).format(this.getDateFormat());
}
return value;

If the user don't want to format the date or if there is no reason to use format (for non date like input), it simply return the raw value.

[icebob]

Not enough, because current date fields (datePicker, pickaday) are stored the data in Unix format without format. If you set format property it will store as a formatted date string. But HTML5 date* field raw format is string. So we always should format this raw values.

I created a fiddle to check the raw values of HTML5 date fields: https://jsfiddle.net/ndz05ku4/2/

[lionel-bijaoui]

What about using inputType ?

if (value != null) {
    if (this.schema.inputType === date ||
        this.schema.inputType === datetime ||
        this.schema.inputType === datetimelocal ||
        this.schema.inputType === time ||
        this.schema.inputType === week ||
        this.schema.inputType === month) {
            if (typeof this.schema.format === "undefined"){
                // Unix formating
            }else{
                return moment(value, this.schema.format).format(this.getDateFormat());
            }
    }
}
return value;

[icebob]

Ok, but skip month and week. They are not full date, can't be format with moment. Stays in string.

[lionel-bijaoui]

I'm skipping time too.

@icebob can you validate this ?

field	value to field	value to model
date	yyyy-MM-dd	UNIX
datetime	yyyy-MM-ddThh:mm	UNIX
datetimelocal	yyyy-MM-ddThh:mm	UNIX
time	hh:mm	hh:mm
week	String	String
month	String	String

[lionel-bijaoui]

Progress: date, datetime and datetime-local can use the same model as pikaday, dateTime (with date format) without problem. Modifying one or the other end in the same model format (UNIX) and update value.
time work well with dateTime (with time format), although Chrome don't allow to input/modify seconds (but display them if set) (if step is defined to 1, then it work) . Edge is fine with seconds.
month and week are treated as string.

methods: {
    formatValueToField(value) {
        switch(this.schema.inputType){
            case "date":
                return moment(value).format("YYYY-MM-DD");
            case "datetime":
                return moment(value).format();
            case "datetime-local":
                return moment(value).format("YYYY-MM-DDTHH:mm:ss");
            default:
                return value;
        }
    },
    formatValueToModel(value) {
        console.log(this.schema.inputType, typeof value);
        if (value != null) {
            if (this.schema.inputType === "date" ||
                this.schema.inputType === "datetime" ||
                this.schema.inputType === "datetimelocal") {
                return new Date(value).getTime();
            }else{
                return value;
            }
        } else {
            return value;
        }
    }
}

[icebob]

Great thank you!

[lionel-bijaoui]

@icebob Can I add a new schema to the commit ?
I have reorganize the fields so that it is easier to use
screenshot

[icebob]

Sure :)

[lionel-bijaoui]

@icebob I think it is ready to merge, no ?

[icebob]

Please remove this log message and after it I will merge.

[lionel-bijaoui]

done

[icebob]

Thanks

[lionel-bijaoui]

You still need to merge, no ? I think you just approved the changes

[icebob]

Just waited the green lights :)

[lionel-bijaoui]

sorry I did not get it 👍