Skip to content

🐛 bug: "Invalid date" message in pikaday field. #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2016
Merged

🐛 bug: "Invalid date" message in pikaday field. #60

merged 1 commit into from
Sep 2, 2016

Conversation

lionel-bijaoui
Copy link
Member

Change dev schema for a simple one. Delete default in pikaday field.
#59

🐛 bug: "Invalid date" message in pikaday field. Change dev schema for…
a45188a 
… a simple one. Delete default in pikaday field
@coveralls
Copy link

coveralls commented Aug 31, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 86.515% when pulling a45188a on lionel-bijaoui:LB_pikaday_invalid_date into 672e656 on icebob:master.

@icebob
Copy link
Member

icebob commented Sep 1, 2016

Why solve it the problem?

@icebob
Copy link
Member

icebob commented Sep 1, 2016

I closed because it is not solved the problem.

@icebob icebob closed this Sep 1, 2016
@lionel-bijaoui
Copy link
Member Author

lionel-bijaoui commented Sep 2, 2016 •
edited
Loading

I agree it does not solve the problem.
But can you remove line 52 to 84 of fieldPikaday.vue ? There is no need for this now that the doc is ready. We don't want to override the default of the plugin with the same option as the default of the plugin, it is pointless.
EDIT: at least, comment them all out, please.

@icebob icebob reopened this Sep 2, 2016
@coveralls
Copy link

coveralls commented Sep 2, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 86.515% when pulling a45188a on lionel-bijaoui:LB_pikaday_invalid_date into 672e656 on icebob:master.

@icebob icebob merged commit bccc910 into vue-generators:master Sep 2, 2016
@icebob
Copy link
Member

icebob commented Sep 2, 2016

Merged

@lionel-bijaoui lionel-bijaoui deleted the LB_pikaday_invalid_date branch September 2, 2016 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lionel-bijaoui @coveralls @icebob