Skip to content

fix: fragment instance warning #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lionel-bijaoui
Copy link
Member

Fix for #45
It seem like a fieldset don't count as a root element for Vue. I added a div and it fix the warning.

@coveralls
Copy link

coveralls commented Aug 26, 2016

Coverage Status

Coverage remained the same at 87.975% when pulling f9915e6 on lionel-bijaoui:LB_fix_fragment_instance into 05fc81c on icebob:master.

@icebob
Copy link
Member

icebob commented Aug 26, 2016

Did you test it with a modal?

@lionel-bijaoui
Copy link
Member Author

lionel-bijaoui commented Aug 26, 2016

No, but Vue.js devtools show a warning when a component is a fragment instance. This simple change fix that warning.
I assume it will fix a lot of problem. Fragment instance is a pain to work with in Vue.js.
I hope @blackfyre will test this and give his feedback.

@icebob
Copy link
Member

icebob commented Aug 26, 2016

Ok, just I test it before merge.

@icebob icebob merged commit a140fc7 into vue-generators:master Aug 26, 2016
@icebob
Copy link
Member

icebob commented Aug 26, 2016

Merged

@lionel-bijaoui lionel-bijaoui deleted the LB_fix_fragment_instance branch August 26, 2016 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants