formGroup now use the correct class name for error when looking for them #519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
form-group
listen for "field-validated" to trigger a search in their DOM childrens for element with a class of ".form-element.error".If they find some, they apply an error class. If not, they add a validation class.
This is a very basic system to detect error in the children of groups (PR welcome if you have an idea to improve this without it being too costly).
The problem is that the error class can be customize with the option
validationErrorClass
.The current
querySelector
doen't take this into account.If you changed
validationErrorClass
, this basic verification system would break and show validation everytime, regardless of the content and state of the children of the group.It now use
validationErrorClass
to get the error class name.No