Add Help in `form-group` #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lionel-bijaoui merged 2 commits into vue-generators:v3 from lionel-bijaoui:lb_help_in_group

Oct 17, 2018

Member

lionel-bijaoui commented Oct 16, 2018

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

What is the current behavior? (You can also link to an open issue here)

If you set the help option in a group, nothing is shown.

What is the new behavior (if this is a feature change)?

The help option is supported. By default show the same thing as help in other fields.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

Other information:
- Use custom slot (group-help)
- Expose group in slot prop
- Update example


          Add Help in form-group

13fa07f

- Use custom slot
- Expose `group` in slot prop
- Update example

lionel-bijaoui requested a review from zoul0813

October 16, 2018 12:50


          Fix submodule version

3b8abe6

lionel-bijaoui merged commit f7195e9 into vue-generators:v3

lionel-bijaoui deleted the lb_help_in_group branch

October 17, 2018 09:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet