Skip to content

Remove Pug #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Conversation

lionel-bijaoui
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

Most fields use Pug as a template language.

  • What is the new behavior (if this is a feature change)?

All the source code is in HTML.
The Eslint rules are more strict.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

Pug prevent ESLint and eslint-plugin-vue from doing their job.
Now, npm run lint will automatically fix (almost) all lint errors.
I also hope that it will reduce the barrier to entry for future contributors to the project.

PS: no real pug where harmed in the making of this PR 🐶 ❤️

Lionel Bijaoui added 2 commits October 5, 2018 14:49
- Convert Pug to HTML
- Allow consistent formating of HTML
- Almost all rules can be fixed automatically by `npm run lint`
- Remove caret from vue-highlightjs
- Update sinon and vue-multiselect
@lionel-bijaoui lionel-bijaoui merged commit 38bbf42 into vue-generators:v3 Oct 5, 2018
@lionel-bijaoui lionel-bijaoui deleted the lb_remove_pug branch October 5, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant