noUiSlider unit test #44
Conversation
|
Thanks. Good solution. Btw, what we test in this external fields: #40 (comment) |
| }); | ||
|
|
||
| } else { | ||
| this.skip(); |
|
Your name doesn't visible in contributors page. https://github.com/icebob/vue-form-generator/graphs/contributors
I think maybe your commits are in a separated branches instead of master of your fork. What do you think? |
|
I've skipped a lot of test, noUiSlider is a bit weird... |
|
Ok, but I write some comment to your commit, ok? |
| done(); | ||
| }); | ||
| } else { | ||
| this.skip(); |
There was a problem hiding this comment.
I think here, we throw an exception if noUISlider is not loaded instead of skip
There was a problem hiding this comment.
Should I do something like this ?
if (typeof(window.noUiSlider) === 'object')
There was a problem hiding this comment.
No, the check is good, but change the this.skip() to throw new Exception("Library is not loaded");
…ue-form-generator into LB_noUiSlider_unit_test
🚧 WIP
I'm able to wait for the initialization of noUiSlider thanks to these slides (n°9 was key).
By appending the
vmto the document, it triggerready, which initialize noUiSlider.Then, I use
vm.$nextTick()to make sure noUiSlider had the time to do it's business (transforming a simple div into a nice slider), ready to test things !For now, nothing important is tested. This was just to show you this solution to test with external libs.