Unscaped html for error msg #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it important to create a new field property? Can we use always |
|
I think you are right. But I've no idea whether this always v-html will result in some XSS attack? |
|
I think XSS is not relevant here because we don't render user input texts, just error messages what comes from the developer. |
|
Yep, I agree with you. So I'll remove the field property and add |
|
Ok 👍 |
icebob
approved these changes
Jan 9, 2018
icebob
requested changes
Jan 9, 2018
src/formGenerator.vue
Outdated
| @@ -14,8 +14,7 @@ div.vue-form-generator(v-if='schema != null') | |||
| button(v-for='btn in field.buttons', @click='buttonClickHandler(btn, field, $event)', :class='btn.classes') {{ btn.label }} | |||
| .hint(v-if='field.hint') {{ fieldHint(field) }} | |||
| .errors.help-block(v-if='fieldErrors(field).length > 0') | |||
| span(v-for='(error, index) in fieldErrors(field)', v-if='field.errorUnescaped', v-html="error", track-by='index') | |||
| span(v-for='(error, index) in fieldErrors(field)', v-if='!field.errorUnescaped', track-by='index') {{ error }} | |||
| span(v-for='(error, index) in fieldErrors(field)', v-html="error", track-by='index') | |||
icebob
approved these changes
Jan 9, 2018
|
Thanks! |
|
With pleasure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a schema property named errorUnescaped to fulfill the situation that the severside return a string with unescaped html.
see: https://jsfiddle.net/7of916d4/2/