Skip to content

fixes #362 - integer validator now calls number validator, and re… #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zoul0813
Copy link
Member

fixes #362 - integer validator now calls number validator, and returns invalidInteger: "The value is not an integer" as well as any errors generated by number

  • wrapped one-liner conditionals/loops with {} (looks cleaner)
  • simplified some conditionals by merging if(cond1) { if(cond2) { } } into if(cond1 && cond2) { }

…idator, and returns `invalidIntegerl: "The value is not an integer"` as well as any errors generated by `number`

* wrapped one-liner conditionals/loops with `{}` (looks cleaner)
* simplified some conditionals by merging `if(cond1) { if(cond2) { } }` into `if(cond1 && cond2) { }`
@zoul0813 zoul0813 self-assigned this Dec 13, 2017
@zoul0813 zoul0813 requested a review from icebob December 13, 2017 16:54
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zoul0813 Thanks. You can merge it if it's done.

…into feature/362-integer-validator

* 'master' of https://github.com/icebob/vue-form-generator:
  fixes vue-generators#361 - use $event.target.valueAsNumber for number/range inputs, debounce `formatValueToModel` for number/range, removed `formatValueToField`

# Conflicts:
#	dist/vfg-core.js
#	dist/vfg.js
@zoul0813 zoul0813 merged commit f4ad588 into vue-generators:master Dec 13, 2017
@zoul0813 zoul0813 deleted the feature/362-integer-validator branch December 13, 2017 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the integer validator
2 participants