Skip to content

added css classes for core fields #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

added css classes for core fields #295

wants to merge 1 commit into from

Conversation

vuchl
Copy link
Contributor

@vuchl vuchl commented Sep 19, 2017

No description provided.

@vuchl vuchl mentioned this pull request Sep 19, 2017
Closed
icebob
icebob requested changes Sep 19, 2017
View reviewed changes
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I have problem with classes name. Because there is a styleClasses in the schema and I think it can cause confusion.
I recommend to use the fieldClasses name instead of classes.

And please fix the travis errors.

@icebob
Copy link
Member

icebob commented Oct 6, 2017

Any updates?

@icebob icebob closed this Oct 10, 2017
@vuchl
Copy link
Contributor Author

vuchl commented Oct 16, 2017

I updated the PR here #318. will try to fix travis errors now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuchl @icebob