Skip to content

Add a props to change the main tag #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2017
Merged

Add a props to change the main tag #198

merged 2 commits into from
May 16, 2017

Conversation

lionel-bijaoui
Copy link
Member

@icebob
Copy link
Member

icebob commented May 16, 2017

Great! But please add relevant test too.

@lionel-bijaoui
Copy link
Member Author

@icebob I don't really know what to test... is is a vuejs feature and I don't know where to begin here. Can you give me a hand ?

@icebob
Copy link
Member

icebob commented May 16, 2017

We here test the root element is a "fieldset". Clone it, set the tag prop and check the result :) Thanks!

@lionel-bijaoui
Copy link
Member Author

Oh ok ! I feared I needed to test everything, what a relief 😅
I do it right now ! Thanks !

@lionel-bijaoui
Copy link
Member Author

@icebob I have beefed up the props with a simple validator. If you feed tag with an empty value, it will fail visibly.
Good to merge ?

icebob
icebob approved these changes May 16, 2017
View reviewed changes
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mergeable. Thanks!

@lionel-bijaoui lionel-bijaoui merged commit a6aaf1b into vue-generators:master May 16, 2017
@lionel-bijaoui lionel-bijaoui deleted the lb_custom_main_tag branch May 16, 2017 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionel-bijaoui @icebob