Skip to content

#159 Vue-multiselect doesn't work properly with objects #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

cristijora
Copy link
Collaborator

@cristijora cristijora commented Mar 20, 2017

Vue-multiselect didn't work properly with objects.
Changed the customLabel function which caused rendering issues by displaying the whole object inside multiselect options instead of the property specified in label
Wrote some unit tests to cover cases when values are initialized with arrays of objects

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! Mergeable

@icebob icebob merged commit 934146c into vue-generators:master Mar 20, 2017
@cristijora cristijora deleted the bug/multiselect-object branch March 20, 2017 13:20
@navjeetfgmnt
Copy link

Hi, i have just installed vue form generator using npm. It seems like this problem still persists. Although, having a deeper look at the source code i found that this fix doesn't come up with the latest npm install.
My package.json
"dependencies": {
"vue": "^2.2.2",
"vue-form-generator": "^2.0.0-beta5",
"vue-multiselect": "2.0.0-beta.13",
"vuex": "^2.2.1"
},

@cristijora
Copy link
Collaborator Author

The PR was merged 15 days ago but the last release was 1 month ago. To answer your question, this fix will be in the next npm release.

@icebob
Copy link
Member

icebob commented Apr 4, 2017

This fix is released in v2.0.0-beta6

@navjeetfgmnt
Copy link

Thanks @icebob . Love your work!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants