Skip to content

Better behavior for radios and checklist #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lionel-bijaoui
Copy link
Member

#145
Now both radios and checklist support array of string array of string or array of objects (with name and value properties) by default.
If respectively radiosOptions or checklistOptions is defined, these key can be replaced by other name, but this is no longer mandatory to use the array of object notation.
The test are updated to test that behavior.

Lionel Bijaoui added 3 commits March 10, 2017 15:56
…`name` and `value` properties) by default. If `radiosOptions` is defined, these key can be replaced by other name, but this is no longer mandatory to use the array of object notation.
…th `name` and `value` properties instead of `name` and `id`) by default. If `checklistOptions` is defined, these key can be replaced by other name. Little change to the error message in `radios` fields. Both fields are harmonized.
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Mergeable

@icebob icebob added this to the v2.0.0 milestone Mar 10, 2017
@lionel-bijaoui lionel-bijaoui merged commit a832b46 into vue-generators:master Mar 10, 2017
@lionel-bijaoui lionel-bijaoui deleted the lb_better_behavior_for_radios_and_checklist branch March 10, 2017 15:44
@lionel-bijaoui
Copy link
Member Author

I'm working on the documentation

@lionel-bijaoui
Copy link
Member Author

I think I'm finished with the doc. Can you review it ? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants