Skip to content

Fix a problem with value define but not an Array #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lionel-bijaoui
Copy link
Member

If the model is initialized with an empty string, when checked/clicked, the push was failing because value is not an array.

model: {
    checklist:''
},
schema: {
    fields: [
            {
            type: "checklist",
            label: "CHECKLIST",
            model: "checklist",
            listBox: true,
            values: [{
                name: "HTML5",
                value: "HTML5-123"
            }, {
                name: "Javascript",
                value: "Javascript-123"
            }],
            }
	]
}
TypeError: this.value.push is not a function

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mergeable

@lionel-bijaoui lionel-bijaoui merged commit bc161f1 into vue-generators:master Mar 10, 2017
@lionel-bijaoui lionel-bijaoui deleted the lb_fix_checklist_value_not_Array branch March 10, 2017 14:02
@icebob icebob added this to the v2.0.0 milestone Mar 10, 2017
@lionel-bijaoui
Copy link
Member Author

I found out that it doesn't really fix the problem. Another PR is coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants