Add a is-checked class to element where the input is checked to ease customisation
#141
Conversation
…e customisation. Add checklist back into the schema of dev
|
Could you add tests, which checks the new classes? |
There was a problem hiding this comment.
@icebob should I continue this way with the other unit test ?
| }); | ||
|
|
||
|
|
||
| describe("test values reactivity to changes", () => { |
There was a problem hiding this comment.
I have grouped the test a little bit, is this okay, and can I do the same thing in checklist's tests ?
| vm.$nextTick( () => { | ||
| expect(model.skills).to.be.equal("HTML5"); | ||
| done(); | ||
| describe("test 'is-checked' class attribution reactivity to changes", () => { |
There was a problem hiding this comment.
Same thing, grouping test for better readability
|
@icebob can you validate what I did, this is blocking my progress on this PR. Thanks ! |
|
I checked & approved your changes, just I thought you will do this grouping on checklist too in this PR. |
| }); | ||
|
|
||
|
|
||
| describe("test values reactivity to changes", () => { |
| vm.$nextTick( () => { | ||
| expect(model.skills).to.be.equal("HTML5"); | ||
| done(); | ||
| describe("test 'is-checked' class attribution reactivity to changes", () => { |
|
Sorry, I haven't been notified of your replies. Of course, I'm going to do the same for checklist, I just wanted to confirm this format before doing it for checklist. |
|
@icebob Is everything OK ? I can merge ? |
|
Ok, mergeable. |
close #140