Form control has label 924 #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashaj
reviewed
Dec 6, 2023
| @@ -5,8 +5,22 @@ makeRuleTester("form-control-has-label", rule, { | |||
| valid: [ | |||
| "<label for=''><input type='text' /></label>", | |||
There was a problem hiding this comment.
Not related to the original issue I had filed, but this line doesn't pass HTML validation:
- An empty string is not allowed for
for - If label has a
forattribute, the nested form control (input). must have an id that matches the value offor.
It's also questionable if a label without text should pass.
…t list of controls to check
vhoyer
force-pushed
the
form-control-has-label-924
branch
from
dfe680b to
d41b34a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely happy with this, anyone want to give opinions and suggestions?