-
-
Notifications
You must be signed in to change notification settings - Fork 29
[Rule Request]: Prohibiting use of aria-hidden and role='presentation' on focusable elements. #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rule Request]: Prohibiting use of aria-hidden and role='presentation' on focusable elements. #1169
Conversation
@kddnewton , @vhoyer. Could you please reiview this PR? Any feedback you provide would be greatly appreciated. |
Hey, could you add a new line at the end of the files that do not have them? github adds a little 🚫 at the end of the file when that's the case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code wise it seems fine, I just don't like nested ifs if I can avoid it, but not a real problem
but prettier is complaining about your formatting, can you pls fix the problems before we merge it? |
Hey @vhoyer. fixed both of them. do check it. |
the docs both seem to still have the final EOL problem |
Hey. not sure what happened earlier. i have added it again for those. |
|
okay i believe it should be resolved now. have a look. |
@@ -0,0 +1,39 @@ | |||
import type { Rule } from "eslint"; | |||
// import type { AST } from "vue-eslint-parser"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be better if we removed the comments, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
…tion' on focusable elements. (#1169) * Added rule for prohibiting use of aria-hidden and role=presentaion on focusable elements * Refactored code into seprate files and utility file * Added EOL for files with prettier errors * Removed nested ifs * Fixed EOL errors * Added more lines * Fixed prettier issues * Removed commented code
aria-hidden
orrole=presentation
on focusable elements #85