Skip to content

test/ava #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 17, 2022
Merged

test/ava #186

merged 6 commits into from
Apr 17, 2022

Conversation

jdbruijn
Copy link
Member

  • test: use AVA for testing instead of Jest
  • refactor(rules): remove Rule<unknown> cast
  • refactor(function-rule): fail fast by checking potential failures and quick returns first
  • ci: remove build check from pre-commit check as it is already covered by the test
  • fix(function-rule): return success if the function rule is undefined

@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #186 (acbb2c9) into main (f654e91) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #186   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           11        84   +73     
  Branches         1         3    +2     
=========================================
+ Hits            11        84   +73     
Impacted Files Coverage Δ
src/function-rule.ts 100.00% <100.00%> (ø)
src/rules.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f654e91...acbb2c9. Read the comment docs.

@jdbruijn jdbruijn merged commit e428a80 into main Apr 17, 2022
@jdbruijn jdbruijn deleted the test/ava branch April 17, 2022 07:48
@ghost
Copy link

ghost commented Apr 17, 2022

🎉 This PR is included in version 1.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant