Skip to content

Start commitlint peer dependency at 9.1.2 #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
jdbruijn opened this issue Feb 24, 2021 · 1 comment
Closed
2 tasks

Start commitlint peer dependency at 9.1.2 #147

jdbruijn opened this issue Feb 24, 2021 · 1 comment
Labels
bug Something isn't working released

Comments

@jdbruijn
Copy link
Member

jdbruijn commented Feb 24, 2021 •
edited
Loading

🐛 Bug report

Steps to reproduce

I guess we would see this plugin failing if used on commitlint 9.0.0 up to 9.1.2.

Expected behaviour

The first version this should work with is commitlint 9.1.1 as that added a required commit for this. The commitlint release notes show the load: resolve plugins from extended configs change, which is required for this plugin.

Edit: It actually needs 9.1.2, which is not documented as change in the changelog, but it requires the @commitlint/lint/src/lint.ts updates from conventional-changelog/commitlint@dabdfc9.

Actual behaviour

Peer dependency 9.x is used.

Environment

Version: x.x.x

Environment information. 
$ npx envinfo --system --binaries
...
  • Change the 9.x version used for testing to 9.1.1.
  • Change peer dependency lower range to >=9.1.2.
@jdbruijn jdbruijn added the bug Something isn't working label Feb 24, 2021
@jdbruijn jdbruijn changed the title Start commitlint peer dependency at 9.1.1 Start commitlint peer dependency at 9.1.2 Feb 24, 2021
ghost pushed a commit that referenced this issue Feb 24, 2021
chore(release): 1.3.1 [skip ci]
7a3812a 
### [1.3.1](v1.3.0...v1.3.1) (2021-02-24)

### Bug Fixes

* **deps:** specify lower peer dependency range as v9.1.2 ([a9f08a5](a9f08a5)), closes [#147](#147)
@ghost
Copy link

ghost commented Feb 24, 2021

🎉 This issue has been resolved in version 1.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdbruijn