ODIN_II: read_blif bug fix #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Odin_II in -b mode, large post-ABC BLIFs cause segfault Unguarded strtok was passing null pointer to strcmp Simply guarded the failed strtok, unclear whether this resolves underlying issue. Similar issue still happens if large BLIFs used in simulator. Also fixed typo.
probot-autolabeler
bot
added
lang-cpp
|
To be clear this does prevent the segfault from happening, just not 100% sure why strtok was failing here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Odin_II in -b mode, large post-ABC BLIFs cause segfault
Unguarded strtok was passing null pointer to strcmp
Simply guarded the failed strtok, unclear whether this resolves
underlying issue.
Similar issue still happens if large BLIFs used in simulator.
Also fixed typo.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: