Skip to content

ODIN II: update response to hard block name collisions #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2019
Merged

ODIN II: update response to hard block name collisions #909

merged 2 commits into from
Aug 13, 2019

Conversation

ademmings
Copy link
Contributor

@ademmings ademmings commented Aug 12, 2019 •
edited
Loading

Description

Odin used to throw a warning when a module was given the same name as a defined hard block, which has now been changed to an error message. Some regression tests had to be updated to accommodate the change.

Some of the tests that we changed were our tests for hard block conversions, so new tests are being added to the regression suite to test these instead.

How Has This Been Tested?

Odin pre-commit regression suite

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@probot-autolabeler probot-autolabeler bot added lang-cpp C/C++ code lang-hdl Hardware Description Language (Verilog/VHDL) Odin Odin II Logic Synthesis Tool: Unsorted item tests labels Aug 12, 2019
@ademmings ademmings changed the title WIP: ODIN II: update response to hard block name collisions ODIN II: update response to hard block name collisions Aug 12, 2019
@jeanlego jeanlego merged commit b88108c into verilog-to-routing:master Aug 13, 2019
@jeanlego jeanlego deleted the hard_block_name_collision branch February 11, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lang-cpp C/C++ code lang-hdl Hardware Description Language (Verilog/VHDL) Odin Odin II Logic Synthesis Tool: Unsorted item tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ademmings @jeanlego