Skip to content

odin: accept files with .sv extension #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

tgorochowik
Copy link
Contributor

This change is needed to make Odin_II accept SystemVerilog files.

Motivation and Context

Using Odin_II with SystemVerilog to potentially see what is there and what is missing.

How Has This Been Tested?

By getting Odin to use a file with the .sv extension.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Not all tests pass on my machine, but they don't pass without this patch either and I don't think they should be affected by this change so I'll just let the CI verify it.

Signed-off-by: Tomasz Gorochowik <[email protected]>
@probot-autolabeler probot-autolabeler bot added lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item labels Aug 8, 2019
@jeanlego
Copy link
Contributor

jeanlego commented Aug 8, 2019

I wouldn't add support for .sv files since we don't support System Verilog.
what could be done is to change the error triggered on unsupported files, to a simple warning and let Odin continue. The warning would let the user know that their files are most likely not supported but we will give it a go.

@ademmings thoughts?

maybe default to an error message unless a flag (i.e. --permissive) is passed, and then use a warning message rather?

@ademmings
Copy link
Contributor

Agreed - we shouldn't accept SV files the way that we accept Verilog files, because it wrongly implies that Odin supports SV. If we want to allow SV files to be passed through for experimental purposes, then a flag/warning would be a better approach.

@jeanlego jeanlego mentioned this pull request Aug 8, 2019
7 tasks
@jeanlego
Copy link
Contributor

jeanlego commented Aug 8, 2019

Closing as we resolve with PR #905

@jeanlego jeanlego closed this Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants