Skip to content

Odin_II: remove deprecated or unmaintained code #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jeanlego
Copy link
Contributor

this PR should fix Coverity issue on write barriers and dangerous API calls.

removing code not being tested and/or used and/or maintained.

Description

this removes the experimental part of the simulator to improve readability and maintainability, as well as reduce coverity errors.

This also removes different adder soft-logic layout to simplify the code and reduce bug.

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@probot-autolabeler probot-autolabeler bot added lang-cpp C/C++ code lang-hdl Hardware Description Language (Verilog/VHDL) lang-shell Shell scripts (bash etc.) Odin Odin II Logic Synthesis Tool: Unsorted item scripts Utility & Infrastructure scripts tests labels Jul 27, 2019
@jeanlego jeanlego force-pushed the odin_remove_exo_code branch from 16c6d98 to c0bdf4a Compare July 27, 2019 14:42
@jeanlego jeanlego changed the title remove deprecated or unmaintained experimental path, … Odinremove deprecated or unmaintained code Jul 27, 2019
@jeanlego jeanlego changed the title Odinremove deprecated or unmaintained code Odin_II: remove deprecated or unmaintained code Jul 27, 2019
@jeanlego jeanlego merged commit 2c1a51e into verilog-to-routing:master Jul 27, 2019
@jeanlego jeanlego deleted the odin_remove_exo_code branch January 21, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-cpp C/C++ code lang-hdl Hardware Description Language (Verilog/VHDL) lang-shell Shell scripts (bash etc.) Odin Odin II Logic Synthesis Tool: Unsorted item scripts Utility & Infrastructure scripts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant