Skip to content

ODIN_II: Fix coverity issue CID 200771: Resource leak #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2019
Merged

ODIN_II: Fix coverity issue CID 200771: Resource leak #812

merged 2 commits into from
Jul 27, 2019

Conversation

j-b-1-7
Copy link
Contributor

@j-b-1-7 j-b-1-7 commented Jul 20, 2019

Description

Should resolve coverity issue CID 200771. Resource leak. Very similiar to PR #811. Need to free stack_of_nodes and it's contents before returning.

How Has This Been Tested?

ODIN pre-commit

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@probot-autolabeler probot-autolabeler bot added lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item labels Jul 20, 2019
@jeanlego
Copy link
Contributor

We don't test this code path by default, the only way to do so would be manually add the flag to the odin_args in the verify odin script to test.
could you run the test locally and report the changes?

@j-b-1-7 j-b-1-7 changed the title ODIN_II: Fix coverity issue CID 200771: Resource leak [WIP]ODIN_II: Fix coverity issue CID 200771: Resource leak Jul 22, 2019
@jeanlego jeanlego changed the title [WIP]ODIN_II: Fix coverity issue CID 200771: Resource leak ODIN_II: Fix coverity issue CID 200771: Resource leak Jul 27, 2019
@jeanlego
Copy link
Contributor

regression test passed

@jeanlego jeanlego merged commit 3d6f3c2 into verilog-to-routing:master Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-b-1-7 @jeanlego