Skip to content

ODIN II: I/O port bug fix #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2019
Merged

ODIN II: I/O port bug fix #702

merged 1 commit into from
Jul 4, 2019

Conversation

ademmings
Copy link
Contributor

Description

Fixed a bug that caused the AST tree to be built incorrectly when declaring inputs and outputs outside of the port list.

How Has This Been Tested?

odin pre-commit regression suite

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@probot-autolabeler probot-autolabeler bot added lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item labels Jul 4, 2019
@jeanlego jeanlego merged commit 849c235 into verilog-to-routing:master Jul 4, 2019
@ademmings ademmings deleted the var_declare_bug branch July 16, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ademmings @jeanlego