Skip to content

ODIN II: fix concatenation and replication; resolve number sizing #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 28, 2019
Merged

ODIN II: fix concatenation and replication; resolve number sizing #686

merged 5 commits into from
Jun 28, 2019

Conversation

ademmings
Copy link
Contributor

@ademmings ademmings commented Jun 28, 2019 •
edited by jeanlego
Loading

Description

This fixes issues with improper concatenation and replication, and adds checks to ensure that concatenation operands are valid. This also properly sizes results when evaluating operations.

Related Issue

closes #101

How Has This Been Tested?

Odin pre-commit regression suite

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@probot-autolabeler probot-autolabeler bot added lang-cpp C/C++ code lang-hdl Hardware Description Language (Verilog/VHDL) Odin Odin II Logic Synthesis Tool: Unsorted item tests labels Jun 28, 2019
@jeanlego
Copy link
Contributor

Can you refer the issue it fixes?

@ademmings
Copy link
Contributor Author

@jeanlego just did as you mentioned it

@ademmings ademmings changed the title WIP: ODIN II: fix concatenation and replication; resolve number sizing ODIN II: fix concatenation and replication; resolve number sizing Jun 28, 2019
@jeanlego
Copy link
Contributor

lgtm! 👍

@jeanlego jeanlego merged commit f4c16ef into verilog-to-routing:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lang-cpp C/C++ code lang-hdl Hardware Description Language (Verilog/VHDL) Odin Odin II Logic Synthesis Tool: Unsorted item tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Odin concatenation parsing
2 participants
@ademmings @jeanlego