Skip to content

Fixed memory leak in get_name_of_pins function in ast_util.cpp #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2019
Merged

Fixed memory leak in get_name_of_pins function in ast_util.cpp #685

merged 3 commits into from
Jul 4, 2019

Conversation

j-b-1-7
Copy link
Contributor

@j-b-1-7 j-b-1-7 commented Jun 28, 2019

Description

Fixed memory leak in get_name_of_pins function in ast_util.cpp where rnode[1] was not being freed.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@probot-autolabeler probot-autolabeler bot added lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item labels Jun 28, 2019
@j-b-1-7 j-b-1-7 changed the title WIP: Fixed memory leak in get_name_of_pins function in ast_util.cpp Fixed memory leak in get_name_of_pins function in ast_util.cpp Jun 28, 2019
@j-b-1-7 j-b-1-7 changed the title Fixed memory leak in get_name_of_pins function in ast_util.cpp WIP: Fixed memory leak in get_name_of_pins function in ast_util.cpp Jul 2, 2019
@j-b-1-7 j-b-1-7 closed this Jul 2, 2019
@jeanlego jeanlego reopened this Jul 4, 2019
@j-b-1-7 j-b-1-7 changed the title WIP: Fixed memory leak in get_name_of_pins function in ast_util.cpp Fixed memory leak in get_name_of_pins function in ast_util.cpp Jul 4, 2019
@jeanlego jeanlego merged commit 0735cae into verilog-to-routing:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-b-1-7 @jeanlego