Skip to content

odin Fixed memory leak in create_single_port_ram_block function in netlist… #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2019
Merged

odin Fixed memory leak in create_single_port_ram_block function in netlist… #663

merged 1 commit into from
Jun 20, 2019

Conversation

j-b-1-7
Copy link
Contributor

@j-b-1-7 j-b-1-7 commented Jun 20, 2019

…_create_from_ast.cpp

Description

Freed the signal_list_t in_list. The objects held by in_list were being freed, but in_list itself was not. This has been fixed.

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • [x ] All new and existing tests passed

@probot-autolabeler probot-autolabeler bot added lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item labels Jun 20, 2019
@j-b-1-7 j-b-1-7 changed the title Fixed memory leak in create_single_port_ram_block function in netlist… WIP: odin Fixed memory leak in create_single_port_ram_block function in netlist… Jun 20, 2019
@jeanlego
Copy link
Contributor

If you remove the WIP this can be merged after Travis finishes

@j-b-1-7 j-b-1-7 changed the title WIP: odin Fixed memory leak in create_single_port_ram_block function in netlist… odin Fixed memory leak in create_single_port_ram_block function in netlist… Jun 20, 2019
@jeanlego
Copy link
Contributor

Lgtm

@jeanlego jeanlego merged commit 35d1036 into verilog-to-routing:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanlego jeanlego jeanlego approved these changes

Assignees
No one assigned
Labels
lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-b-1-7 @jeanlego