ODIN_DEBUG: Fix for [0:0] data width segmentation fault #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP ODIN_DEBUG: Fix for [0:0] data width segmentation fault SRC: netlist_create_from_ast.cpp Signed-off-by: Hillary Soontiens <[email protected]>
probot-autolabeler
bot
added
lang-cpp
|
good catch! If you remove the WIP ill merge it! |
|
I tested DPR on its own just now and yes, I believe so! I can show you the output to confirm before merging. |
|
Make sure you run [path to vtr root directory]/ODIN_II/verify_odin.sh --test pre_commit |
jeanlego
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP ODIN_DEBUG: Fix for [0:0] data width crash using SPR
SRC: netlist_create_from_ast.cpp
Signed-off-by: Hillary Soontiens [email protected]
Description
A function call to create a node's full name was fixed so that it would properly insert the end of the name in the case of a data width (port size) of 1.
Related Issue
The bug would cause a segmentation fault when specifying a data width of 1 in memory_controller.v and running it on odin_II.cpp. The issue seemed to arise because when using single-port-ram, certain input drivers could not be detected mid-synthesis.
Motivation and Context
Having a data width of 1 is a valid special case.
How Has This Been Tested?
memory_controller.v was tested primarily, using data/address widths of 1/1, 2/1, 2/2 as well as other larger values.
Types of changes
Checklist: