Skip to content

[AP][Legalizer] Added Ability to Generate a Mass Report #3095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions doc/src/vpr/command_line_usage.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1336,6 +1336,15 @@ Analytical Placement is generally split into three stages:

**Default:** ``1``

.. option:: --ap_generate_mass_report {on | off}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the report and noticed that there is no AP-specific section in it. So, I think it might be better to change the name of the option to avoid implying that it's AP-specific, and instead treat it as one of the general options for generating a report.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mass calculation is AP specific, the report cannot be generated outside of the AP flow. The drawing of the complex graph is useful for understanding the mass report, hence why it is part of this report.

I do not want to gate this PR on this, but in a future PR I can move this to an external report which reports on the structure of the architecture file. I think that is beyond the scope of this PR and would include more features. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Let's do it in another PR.


Controls whether to generate a report on how the partial legalizer
within the AP flow calculates the mass of primitives and the
capacity of tiles on the device. This report is useful when
debugging the partial legalizer.

**Default:** ``off``


.. _router_options:

Expand Down
1 change: 1 addition & 0 deletions vpr/src/analytical_place/analytical_placement_flow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ static PartialPlacement run_global_placer(const t_ap_opts& ap_opts,
device_ctx.physical_tile_types,
pre_cluster_timing_manager,
ap_opts.ap_timing_tradeoff,
ap_opts.generate_mass_report,
ap_opts.num_threads,
ap_opts.log_verbosity);
return global_placer->place();
Expand Down
Loading