Clean up the usage tracking in grid blocks. #3088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
There was a problem hiding this comment.
Looks good @haydar-c ! It looks like this get_usage method was only used for drawing, logging, and verification which are not performance critical. I agree with removing the usage value and having it be dynamically calculated for simplicity.
I left a small comment on documentation, other than that it looks good to me!
|
Thank you for reviewing @AlexandreSinger! I've just added documentation for get_usage. |
vpr/src/base/grid_block.cpp
Outdated
| @@ -31,7 +31,6 @@ void GridBlock::zero_initialize() { | |||
| for (int layer_num = 0; layer_num < (int)device_ctx.grid.get_num_layers(); layer_num++) { | |||
| for (int i = 0; i < (int)device_ctx.grid.width(); i++) { | |||
| for (int j = 0; j < (int)device_ctx.grid.height(); j++) { | |||
| set_usage({i, j, layer_num}, 0); | |||
| auto tile = device_ctx.grid.get_physical_type({i, j, layer_num}); | |||
There was a problem hiding this comment.
Could you replace auto with explicit type names?
AlexandreSinger
approved these changes
May 27, 2025
|
Thank you @soheilshahrouz for reviewing! I have changed the auto types to explicit ones for grid blocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unused 'usage' member from t_grid_blocks and all associated routines of set_usage, increment_usage, decrement_usage (get_usage changed as below).
Description
Changes:
get_usage()to dynamically count valid blocks based on sub-tile occupancy.Related Issue
This PR resolves the issue #1607