Skip to content

[CI] Removed Redundant Warning Test #3079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
+1 −70
Merged

[CI] Removed Redundant Warning Test #3079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,38 +125,6 @@ jobs:
run: ./.github/scripts/unittest.sh


Warnings:
name: 'W: Check Compilation Warnings'
runs-on: ubuntu-24.04
steps:

- uses: actions/setup-python@v5
with:
python-version: 3.12.3
- uses: actions/checkout@v4
with:
submodules: 'true'

- name: Get number of CPU cores
uses: SimenB/github-actions-cpu-cores@v2
id: cpu-cores

- name: Install dependencies
run: ./.github/scripts/install_dependencies.sh

- uses: hendrikmuhs/[email protected]

- name: Test
env:
#In order to get compilation warnings produced per source file, we must do a non-IPO build
#We also turn warnings into errors for this target by doing a strict compile
CMAKE_PARAMS: "-DVTR_ASSERT_LEVEL=3 -DWITH_BLIFEXPLORER=on -DVTR_ENABLE_STRICT_COMPILE=on -DVTR_IPO_BUILD=off"
NUM_PROC: ${{ steps.cpu-cores.outputs.count }}
run: |
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
./.github/scripts/build.sh


Regression:
runs-on: ubuntu-24.04
strategy:
Expand Down Expand Up @@ -517,7 +485,6 @@ jobs:
- Build
- Format
- UniTests
- Warnings
- Regression
- Sanitized
- Parmys
Expand Down
1 change: 0 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ set_property(CACHE VTR_IPO_BUILD PROPERTY STRINGS auto on off)
set(VTR_ASSERT_LEVEL "2" CACHE STRING "VTR assertion checking level. 0: no assertions, 1: fast assertions, 2: regular assertions, 3: additional assertions with noticeable run-time overhead, 4: all assertions (including those with significant run-time cost)")
set_property(CACHE VTR_ASSERT_LEVEL PROPERTY STRINGS 0 1 2 3 4)

option(VTR_ENABLE_STRICT_COMPILE "Specifies whether compiler warnings should be treated as errors (e.g. -Werror)" OFF)
option(VTR_ENABLE_SANITIZE "Enable address/leak/undefined-behaviour sanitizers (i.e. run-time error checking)" OFF)
option(VTR_ENABLE_PROFILING "Enable performance profiler (gprof)" OFF)
option(VTR_ENABLE_COVERAGE "Enable code coverage tracking (gcov)" OFF)
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ override CMAKE_PARAMS := -DCMAKE_BUILD_TYPE=$(CMAKE_BUILD_TYPE) -G 'Unix Makefil
#Are we doing a strict (i.e. warnings as errors) build?
ifneq (,$(findstring strict,$(BUILD_TYPE)))
#Configure for strict build with VPR warning treated as errors
override CMAKE_PARAMS := -DVTR_ENABLE_STRICT_COMPILE=on ${CMAKE_PARAMS}
override CMAKE_PARAMS := -DCMAKE_COMPILE_WARNING_AS_ERROR=on ${CMAKE_PARAMS}
endif #Strict build type

#Enable verbosity
Expand Down
17 changes: 0 additions & 17 deletions odin_ii/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,22 +190,5 @@ if (ODIN_USES_IPO)
set_property(TARGET odin_ii APPEND PROPERTY LINK_FLAGS ${IPO_LINK_WARN_SUPRESS_FLAGS})
endif()

#add strict odin compiler flags, if set
if(VTR_ENABLE_STRICT_COMPILE)
message(STATUS "odin_ii: building with strict flags")

set(ODIN_STRICT_COMPILE_FLAGS_TO_CHECK
#GCC-like
"-Werror"
)

foreach(flag ${ODIN_STRICT_COMPILE_FLAGS_TO_CHECK})
message(STATUS "\tAdding CXX flag: ${flag}")
target_compile_options(libodin_ii PRIVATE ${flag})
target_compile_options(odin_ii PRIVATE ${flag})
target_link_libraries(odin_ii ${flag})
endforeach()
endif()

install(TARGETS odin_ii libodin_ii DESTINATION bin)
install(FILES ${LIB_HEADERS} DESTINATION include/libodin_ii)
18 changes: 0 additions & 18 deletions vpr/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,24 +227,6 @@ else()
message(ERROR "Unsupported VPR_PGO_CONFIG '${VPR_PGO_CONFIG}'")
endif()

if (VTR_ENABLE_STRICT_COMPILE)
message(STATUS "VPR: building with strict flags")

set(VPR_STRICT_COMPILE_FLAGS_TO_CHECK
#GCC-like
"-Werror"
# due to the pointer hackery in timing_driven_route_structs and BinaryHeap.heap_
"-Wno-error=free-nonheap-object"
Comment on lines -236 to -237
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this flag set anywhere else. I assume it's not needed anymore and was here just because of legacy reasons.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. The fact that we are no longer getting this warning anymore indicates that this was fixed at some point.

)

foreach(flag ${VPR_STRICT_COMPILE_FLAGS_TO_CHECK})
message(STATUS "\tAdding CXX flag: ${flag}")
target_compile_options(libvpr PRIVATE ${flag})
target_compile_options(vpr PRIVATE ${flag})
target_link_libraries(vpr ${flag})
endforeach()
endif()

#
# Execution Engine Configuration
#
Expand Down